Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split http gateway into seperate command #54

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Aug 11, 2021

What this PR does / why we need it:

The running of the gRPC gateway has been split out into a separate command so that it becomes an optional component.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #52

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Remove the gRPC HTTP gateway into a separate command.

@richardcase richardcase added the kind/refactor Only refactoring changes label Aug 11, 2021
The running of the gRPC gateway has been split out into a separate
command so that it becomes an optional component.

Signed-off-by: Richard Case <[email protected]>
@richardcase richardcase merged commit 074b7d0 into main Aug 11, 2021
@richardcase richardcase deleted the 52_separate_gw branch August 11, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Only refactoring changes size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split gRPC Gateway out into separate executable or command.
1 participant