feat: add pprof to flintlock #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Callisto13 - i was thinking instead of using |
Callisto13
previously approved these changes
Aug 18, 2022
🤔 yeh an address might make sense |
yitsushi
previously approved these changes
Aug 18, 2022
This change adds the ability to make pprof available via http. By default it won't be available. If you specify a debug endpoint via `--debug-endpoint` then it will start a webserver listening at that endpoint and pprof is available from there. We decided to use an endpoint as that will allow users to only expose the debug endpoint locally or via the network. Signed-off-by: Richard Case <[email protected]>
Callisto13
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds the ability to make pprof available via http. By
default it won't be available. If you specify a debug endpoint via
--debug-endpointthen it will start a webserver listening at thatendpoint and pprof is available from there.
We decided to use an endpoint as that will allow users to only expose
the debug endpoint locally or via the network.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Relates #503
Special notes for your reviewer:
Checklist: