feat: added grpc service definition and unimplemented server #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
changed the title
bigkevmcd
reviewed
Aug 2, 2021
Added the grpc service definition for reignited. Updated the tools with the protobuf/grpc go generators. Refactored the layout of the `api` folder to allow for future additional api definitions to be added. Signed-off-by: Richard Case <[email protected]>
Signed-off-by: Richard Case <[email protected]>
Added a new command to server the grpc service. This currently serves an unimplemented service that will error if any of the rpc methods are called. Also, added the gateway and openapi code generation. Signed-off-by: Richard Case <[email protected]>
Update the proto definition to explicitly state the http options for the grpc gateway. Also changed the names of the service methods and associated messages to follow the google naming conventions. Signed-off-by: Richard Case <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added the grpc service definition for reignited. Based on this definition the command to serve the api has been added and an unimplemented version of the server has been added for future implementation.
Updated the tools with the protobuf/grpc/gateway/openapi go generators.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #26
Fixes #27
Special notes for your reviewer:
Checklist:
Release note: