feat: added skeleton firecracker provider #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the existing microvm provider package to remove the provider registry and lazy init. Initially we will only have 1 provider and perhaps add an additional one (cloud hypervisor) in the future and so we don't need a registry. The functions of the firecracker provider are just skeletons and return errors in most instances. The functions will be added over time. Signed-off-by: Richard Case <[email protected]>
bigkevmcd
requested changes
Aug 2, 2021
Various changes as a result of code review. The most significant being that the flags are now added using the supplied command and not the supplied flagset. Signed-off-by: Richard Case <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refactored the existing microvm provider package to remove the provider registry and lazy init. Initially we will only have 1 provider and perhaps add an additional one (cloud hypervisor) in the future and so we don't need a registry.
The functions of the firecracker provider are just skeletons and return errors in most instances. The functions will be added
over time.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #37
Fixes #38
Special notes for your reviewer:
Checklist:
Release note: