feat: added grpc proxy dial option to client package #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some consumers (i.e. capmvm) may need to use an explicit proxy server instead of relying on the env levels http proxy settings/ Signed-off-by: Richard Case <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 56.58% 56.55% -0.04%
==========================================
Files 52 52
Lines 2603 2603
==========================================
- Hits 1473 1472 -1
Misses 1006 1006
- Partials 124 125 +1
Continue to review full report at Codecov.
|
|
No tests? |
As it was adapted code from elsewhere I didn't add them but that was lazy. I'll add them. |
yitsushi
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some consumers (i.e. capmvm) may need to use an explicit proxy server
instead of relying on the env levels http proxy settings.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: