feat: added microvm spec & repository #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added API definition for a MicroVM and a MicroVMList. Created a repository that do get/save/delete instances of the api. A implementation that uses the containerd content store has been added. Signed-off-by: Richard Case <[email protected]>
bigkevmcd
reviewed
Jul 28, 2021
| "github.com/weaveworks/reignite/pkg/defaults" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
These are exported, should probably have a doc comment?
pkg/repository/microvm.go
Outdated
| ) | ||
|
|
||
| // MicroVM is the repoitory definition for a microvm repository. | ||
| type MicroVM interface { |
There was a problem hiding this comment.
This might be better named Store or Repository or something similar to avoid MicroVM being both a place to store things, and a thing to be stored there?
pkg/repository/microvm_test.go
Outdated
| ctx := context.Background() | ||
|
|
||
| store, contentDir := getLocalContentStore(t) | ||
| defer os.RemoveAll(contentDir) |
There was a problem hiding this comment.
You could use t.Cleanup() here?
(bonus points for adding it in the getLocalContentStore function, because it would be triggered when the test was being cleaned up).
Various changes as a result of code review, inclduing: * Changing the name of the repository interface * Cleaning up temporary dis during testing. Signed-off-by: Richard Case <[email protected]>
bigkevmcd
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added API definition for a MicroVM and a MicroVMList. Created a repository that do get/save/delete instances of the api. A
implementation that uses the containerd content store has been added.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #24
Fixes #25
Special notes for your reviewer:
Checklist:
Release note: