feat: added DELETING microvm status
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new microvm status (spec only) that is set when we send a request to delete a microvm. This means that an subsequent gets (before reconcile is run) we can see that the microvm has a status of deleting. Signed-off-by: Richard Case <[email protected]>
richardcase
added
kind/feature
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 58.06% 57.91% -0.15%
==========================================
Files 51 51
Lines 2506 2509 +3
==========================================
- Hits 1455 1453 -2
- Misses 935 939 +4
- Partials 116 117 +1
Continue to review full report at Codecov.
|
yitsushi
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added a new microvm status (spec only) that is set when we send a
request to delete a microvm. This means that an subsequent gets (before
reconcile is run) we can see that the microvm has a status of deleting.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #310
Special notes for your reviewer:
Checklist: