chore(test): Get only first output from create func #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
reviewed
Dec 16, 2021
| @@ -99,7 +99,7 @@ def create_device(config_file, org_id, project_id, device_name, userdata): | |||
| f"Creating device {cfg['device']['name']} with config {pretty}") | |||
|
|
|||
| welder = Welder(token, cfg) | |||
| ip = welder.create_all() | |||
| ip = welder.create_all()[0] | |||
There was a problem hiding this comment.
Can the call to welder.create_all() fail? Although this question has no bearing on the change.
There was a problem hiding this comment.
yes it can, but it has no impact on what that value is used for, as i have neglected to handle any errors properly and they just panic 😜
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
==========================================
- Coverage 58.07% 57.95% -0.12%
==========================================
Files 51 51
Lines 2509 2509
==========================================
- Hits 1457 1454 -3
- Misses 937 938 +1
- Partials 115 117 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small thing I did not notice at the time.