Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json tags on cloudinit Metadata #319

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

yitsushi
Copy link
Contributor

@yitsushi yitsushi commented Dec 13, 2021

What this PR does / why we need it:

Add json tags on the Metadata struct, so when we marshal it, it uses the same naming as the yaml format (and the one we are using right now as a key-value string).

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes

@yitsushi yitsushi added the kind/cleanup Removing things previously overlooked label Dec 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #319 (b8d0ab1) into main (7213b9c) will decrease coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   58.15%   57.95%   -0.20%     
==========================================
  Files          51       51              
  Lines        2509     2509              
==========================================
- Hits         1459     1454       -5     
- Misses        935      938       +3     
- Partials      115      117       +2     
Impacted Files Coverage Δ
pkg/queue/queue.go 93.93% <0.00%> (-6.07%) ⬇️
infrastructure/containerd/event_service.go 56.14% <0.00%> (-3.51%) ⬇️
pkg/process/process.go 37.73% <0.00%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7213b9c...b8d0ab1. Read the comment docs.

@yitsushi yitsushi merged commit 5f8d70c into liquidmetal-dev:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Removing things previously overlooked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants