Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump firecracker version to v0.25.2 #317

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 13, 2021

This is an automatically generated PR to bump the version of firecracker
in our tests. There are some manual steps to get new releases of our fork
branch published.
This PR is to track those manual steps.

To complete work on this PR:

  • Update (merge or rebase) the fork macvtap feature branch to the latest upstream release tag v0.25.2. Note: Do not update the feature branch to upstream main.
  • Make sure it builds. (See: doc)
  • Push the updated firecracker 'feature/macvtap' fork branch.
  • Create a new tag on the updated firecracker 'feature/macvtap' fork branch: git tag -s v0.25.2-macvtap -m v0.25.2-macvtap.
  • Push the tag to the fork: git push <remote> v0.25.2-macvtap (A new release will be created.)
  • In this repo, trigger the nightly_e2e workflow to run on the bump-firecracker-04e639db56f2b95998ffd13b1dd8f555d11c5d7e branch.
  • Once the tests have passed:
    • Edit the title of this PR to remove the 'WIP'
    • Mark this PR as ready to review
    • Approve and merge

Auto-generated by create-pull-request.

@github-actions github-actions bot added area/dependency Issues or PRs related to dependency changes area/firecracker Indicates an issue or PR related to Firecracker area/testing Indicates an issue related to test kind/feature New feature or request labels Dec 13, 2021
@Callisto13 Callisto13 self-assigned this Dec 13, 2021
@Callisto13 Callisto13 changed the title WIP chore(deps): bump firecracker version to v0.25.2 chore(deps): bump firecracker version to v0.25.2 Dec 13, 2021
@Callisto13 Callisto13 marked this pull request as ready for review December 13, 2021 09:59
Callisto13
Callisto13 previously approved these changes Dec 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #317 (ca6acf0) into main (d045e5f) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   57.94%   57.98%   +0.03%     
==========================================
  Files          51       51              
  Lines        2506     2506              
==========================================
+ Hits         1452     1453       +1     
  Misses        937      937              
+ Partials      117      116       -1     
Impacted Files Coverage Δ
pkg/process/process.go 39.62% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d045e5f...ca6acf0. Read the comment docs.

@Callisto13 Callisto13 force-pushed the bump-firecracker-04e639db56f2b95998ffd13b1dd8f555d11c5d7e branch from ca6acf0 to dba1e3d Compare December 13, 2021 11:34
@Callisto13 Callisto13 merged commit 12eb536 into main Dec 13, 2021
@Callisto13 Callisto13 deleted the bump-firecracker-04e639db56f2b95998ffd13b1dd8f555d11c5d7e branch December 13, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes area/firecracker Indicates an issue or PR related to Firecracker area/testing Indicates an issue related to test kind/feature New feature or request size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants