refactor: cloudinit pointer removal #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small refactor to the **cloudinit** package to remove pointers where possible so that its more user friendly to consume. In the struct definitions we have tried to remove usage of pointers and instead rely on the behavior of json marshalling and `omitempty`. Its slightly tricky with boolean values so for these we use *bool vs bool. The reason is that the default value for some cloudinit values is true which isn't the same as the default for bool. Signed-off-by: Richard Case <[email protected]>
4 tasks
dlopro
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A small refactor to the cloudinit package to remove pointers where
possible so that its more user friendly to consume.
In the struct definitions we have tried to remove usage of pointers and instead rely on the behavior of json
marshalling and
omitempty. Its slightly tricky with boolean values so for these we use *bool vs bool. Thereason is that the default value for some cloudinit values is true which isn't the same as the default for bool.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: