Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait for pidfile #298

Merged
merged 2 commits into from
Nov 30, 2021
Merged

fix: wait for pidfile #298

merged 2 commits into from
Nov 30, 2021

Conversation

yitsushi
Copy link
Contributor

@yitsushi yitsushi commented Nov 30, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@yitsushi yitsushi added kind/bug Something isn't working area/testing Indicates an issue related to test labels Nov 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #298 (6f4ec07) into main (bfe06dc) will not change coverage.
The diff coverage is n/a.

❗ Current head 6f4ec07 differs from pull request most recent head edb1fec. Consider uploading reports for the commit edb1fec to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   59.23%   59.23%           
=======================================
  Files          49       49           
  Lines        2399     2399           
=======================================
  Hits         1421     1421           
+ Misses        869      868    -1     
- Partials      109      110    +1     
Impacted Files Coverage Δ
pkg/queue/queue.go 93.93% <0.00%> (-6.07%) ⬇️
infrastructure/containerd/event_service.go 59.64% <0.00%> (+3.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe06dc...edb1fec. Read the comment docs.

@yitsushi
Copy link
Contributor Author

e2e run: https://github.com/weaveworks/flintlock/actions/runs/1520405713

Failed, but unrelated:

time="2021-11-30T10:39:08Z" level=error msg="failed to reconcile vmid ns0/mvm0: executing plan: executing plan steps: executing steps: executing step runtime_volume_mount: mount images docker.io/richardcase/ubuntu-bionic-test:cloudimage_v0.0.1 for volume use: getting image docker.io/richardcase/ubuntu-bionic-test:cloudimage_v0.0.1 for owner ns0/mvm0: pulling image using containerd: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/richardcase/ubuntu-bionic-test/manifests/sha256:371792335fe2360e0fd30108e42eb565c990140aeb9bcc796de10a59da54beb6: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit" controller=microvm
429 Too Many Requests - Server message: toomanyrequests:
  You have reached your pull rate limit.
  You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@yitsushi
Copy link
Contributor Author

yitsushi commented Nov 30, 2021

New run hope it will not hit rate limit now: https://github.com/weaveworks/flintlock/runs/4366216033?check_suite_focus=true

Nope it's still rate limit:

time="2021-11-30T10:54:25Z" level=error msg="failed to reconcile vmid ns0/mvm0: executing plan: executing plan steps: executing steps: executing step runtime_volume_mount: mount images docker.io/richardcase/ubuntu-bionic-test:cloudimage_v0.0.1 for volume use: getting image docker.io/richardcase/ubuntu-bionic-test:cloudimage_v0.0.1 for owner ns0/mvm0: pulling image using containerd: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/richardcase/ubuntu-bionic-test/manifests/sha256:371792335fe2360e0fd30108e42eb565c990140aeb9bcc796de10a59da54beb6: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit" controller=microvm
429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit.

test/e2e/e2e_test.go Outdated Show resolved Hide resolved
@yitsushi
Copy link
Contributor Author

@Callisto13
Copy link
Member

10th time's the charm :trollface:

@yitsushi yitsushi merged commit 85d735b into main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Indicates an issue related to test kind/bug Something isn't working size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants