chore(test): Tidy up python tool #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know whether this is the correct way to structure a python project, but it was getting a bit messy in that dir so I have moved things around. Also the Welder package can probably be refactored one day.
Callisto13
force-pushed
the
fix-nightly
branch
from
ed55299 to
a934f9d
Compare
yitsushi
approved these changes
Nov 16, 2021
| @@ -8,7 +8,7 @@ | |||
| class Config: | |||
| def __init__(self): | |||
| self.dir = dirname(abspath(__file__)) | |||
| self.base = dirname(dirname(dirname(abspath(__file__)))) | |||
| self.base = dirname(dirname(dirname(dirname(abspath(__file__))))) | |||
There was a problem hiding this comment.
Maybe with pathlib.Path it's more readable:
from pathlib import Path
Suggested change
| self.base = dirname(dirname(dirname(dirname(abspath(__file__))))) | |
| self.base = str(Path(abspath(__file__)).parent.parent.parent.parent) |
There was a problem hiding this comment.
In theory, parents[4] should work too, but then we have to check the length first
There was a problem hiding this comment.
Maybe with
pathlib.Pathit's more readable
maybe, i will add that with my next pr in all the places we do this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Only the second commit does anything new, the rest is tidying up.
The main purpose of this PR is to fix the e2e nightly build. I think I must
have messed up a rebase or something because I had run the exact
command so many times and it was fine so 🤷♀️ .
I also did a bit of tidying up in the
test/tools/dir. i have no idea howa python project should be structured (even a toy one like this) but it was a
bit messy in there and there is much room for refactoring and tests so
organising things better now felt sensible.