Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ADR for opinionated API changes #262

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

jmickey
Copy link
Contributor

@jmickey jmickey commented Nov 15, 2021

What this PR does / why we need it:

This PR adds the accepted ADR for Opinionated API Changes and Rational Defaults as per discussions #241.

@jmickey jmickey added kind/documentation Documentation only area/api Indicates an issue or PR relates to the APIs labels Nov 15, 2021
@jmickey jmickey requested a review from a team November 15, 2021 11:39
@jmickey jmickey self-assigned this Nov 15, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #262 (7d2da7b) into main (aa5916e) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   40.29%   40.20%   -0.10%     
==========================================
  Files          46       46              
  Lines        2169     2169              
==========================================
- Hits          874      872       -2     
- Misses       1236     1237       +1     
- Partials       59       60       +1     
Impacted Files Coverage Δ
pkg/queue/queue.go 93.93% <0.00%> (-6.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5863d...7d2da7b. Read the comment docs.

@jmickey jmickey force-pushed the docs/opinionated-api-changes-adr branch from 7d2da7b to 6d82cdb Compare November 15, 2021 12:22
@jmickey jmickey merged commit 0413a15 into main Nov 15, 2021
@jmickey jmickey deleted the docs/opinionated-api-changes-adr branch November 15, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue or PR relates to the APIs kind/documentation Documentation only size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants