Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the e2es as part of the release process #254

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

Callisto13
Copy link
Member

We should not release anything unless we know it is at least not
catastrophically broken.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

We should not release anything unless we know it is at least not
catastrophically broken.
@Callisto13 Callisto13 added the kind/feature New feature or request label Nov 12, 2021
@Callisto13 Callisto13 requested a review from a team November 12, 2021 12:50
@codecov-commenter
Copy link

Codecov Report

Merging #254 (2d33f6f) into main (fe9bb9f) will decrease coverage by 15.61%.
The diff coverage is 41.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #254       +/-   ##
===========================================
- Coverage   55.81%   40.20%   -15.62%     
===========================================
  Files          44       46        +2     
  Lines        2012     2169      +157     
===========================================
- Hits         1123      872      -251     
- Misses        781     1237      +456     
+ Partials      108       60       -48     
Impacted Files Coverage Δ
core/application/commands.go 71.66% <ø> (+2.70%) ⬆️
core/application/reconcile.go 0.00% <ø> (ø)
core/models/vmid.go 90.24% <ø> (ø)
core/models/volumes.go 0.00% <ø> (ø)
core/steps/microvm/delete.go 100.00% <ø> (ø)
core/steps/runtime/dir_create.go 73.07% <ø> (ø)
core/steps/runtime/dir_delete.go 81.81% <ø> (ø)
core/steps/runtime/initrd_mount.go 100.00% <ø> (ø)
core/steps/runtime/kernel_mount.go 100.00% <ø> (ø)
infrastructure/containerd/content.go 0.00% <0.00%> (-100.00%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be94a0...2d33f6f. Read the comment docs.

@yitsushi
Copy link
Contributor

Can we automate somehow this workflow: "create pre-release -> e2e -> release" ?

@Callisto13
Copy link
Member Author

Can we automate somehow this workflow: "create pre-release -> e2e -> release" ?

I don't think we do release yet, seems to be just pre-releases while in alpha, but yeh there are some manual steps that it would be good to automate out in general

@Callisto13 Callisto13 merged commit 3094d48 into liquidmetal-dev:main Nov 12, 2021
@Callisto13 Callisto13 deleted the e2es-on-release branch November 12, 2021 13:34
Callisto13 added a commit to Callisto13/flintlock that referenced this pull request Nov 12, 2021
We should not release anything unless we know it is at least not
catastrophically broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants