Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial project setup and provider interface definition #23

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Jul 12, 2021

What this PR does / why we need it:
This provides the initial project setup and provider interface definition. The provider plugins will register themselves with the register following the same pattern as kubectl with _ imports and init functions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5
Fixes #4

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Initial project setup

@richardcase richardcase added the kind/feature New feature or request label Jul 12, 2021
bigkevmcd
bigkevmcd previously approved these changes Jul 12, 2021
pkg/provider/registry/registry_test.go Outdated Show resolved Hide resolved
pkg/provider/registry/registry.go Outdated Show resolved Hide resolved
pkg/provider/registry/registry.go Show resolved Hide resolved
pkg/provider/registry/registry.go Outdated Show resolved Hide resolved
palemtnrider
palemtnrider previously approved these changes Jul 12, 2021
Copy link

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/provider/registry/registry.go Show resolved Hide resolved
@richardcase richardcase dismissed stale reviews from palemtnrider and bigkevmcd via c7b48b9 July 13, 2021 08:54
@richardcase richardcase force-pushed the provider_def branch 2 times, most recently from be196f0 to 4c0da91 Compare July 13, 2021 13:32
Incorporated changes from code review.

Signed-off-by: Richard Case <[email protected]>
@richardcase richardcase merged commit b39634a into main Jul 28, 2021
@richardcase richardcase deleted the provider_def branch July 28, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/l
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MicroVM Provider/Plugin Definition Project Skaffolding
3 participants