chore(deps): bump github.com/onsi/gomega from 1.16.0 to 1.17.0

[dependabot]

Bumps github.com/onsi/gomega from 1.16.0 to 1.17.0.

Release notes

Sourced from github.com/onsi/gomega's releases.

v1.17.0

1.17.0

Features

• Add HaveField matcher [3a26311]
• add Error() assertions on the final error value of multi-return values (#480) [2f96943]
• separate out offsets and timeouts (#478) [18a4723]
• fix transformation error reporting (#479) [e001fab]
• allow transform functions to report errors (#472) [bf93408]

Fixes

Stop using deprecated ioutil package (#467) [07f405d]

Changelog

Sourced from github.com/onsi/gomega's changelog.

1.17.0

Features

• Add HaveField matcher [3a26311]
• add Error() assertions on the final error value of multi-return values (#480) [2f96943]
• separate out offsets and timeouts (#478) [18a4723]
• fix transformation error reporting (#479) [e001fab]
• allow transform functions to report errors (#472) [bf93408]

Fixes

Stop using deprecated ioutil package (#467) [07f405d]

Commits

• 05f6097 v1.17.0
• 3a26311 Add HaveField matcher
• 2f96943 add Error() assertions on the final error value of multi-return values (#480)
• 18a4723 separate out offsets and timeouts (#478)
• e001fab fix transformation error reporting (#479)
• 61cd3b8 Fix typo (#477)
• bf93408 allow transform functions to report errors (#472)
• 07f405d chore: stop using deprecated ioutil package (#467)
• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[Callisto13]

Okay i don't know why this is failing and I am not in the mood today.

When the action runs it fails with:

Error: /root/go/pkg/mod/github.com/onsi/[email protected]/matchers/have_http_body_matcher.go:84:30: undefined: io.ReadAll
Error: /root/go/pkg/mod/github.com/onsi/[email protected]/matchers/have_http_status_matcher.go:81:16: undefined: io.ReadAll
note: module requires Go 1.16

When I SSH into the machine in which the action is being run and run make test-with-cov it is fine.

When I fetch this branch down locally and run it is fine.

[Callisto13]

Solved

So we setup our action with go 1.17. However the ubuntu machine sets up an earlier version of go by default (1.15) (remember i said that the ubuntu machine images come with tons of crap?). When we add 1.17 it is added for the non-root user only. Our action is running sudo ... make test so it is running with 1.15. When I sshed on to the action machine initially
i ran the command as non-root so could not repro

gomega now has a dependency which uses something which did not exist in 1.15, so the action fails.
so this is a right pain in the ass gotcha

This is known in the setup action, but i doubt anything will be done about it

[codecov-commenter]

Codecov Report

Merging #229 (909c9fb) into main (fe9bb9f) will decrease coverage by 15.04%.
The diff coverage is 70.73%.

❗ Current head 909c9fb differs from pull request most recent head 9efcd18. Consider uploading reports for the commit 9efcd18 to get more accurate results

@@             Coverage Diff             @@
##             main     #229       +/-   ##
===========================================
- Coverage   55.81%   40.76%   -15.05%     
===========================================
  Files          44       46        +2     
  Lines        2012     2139      +127     
===========================================
- Hits         1123      872      -251     
- Misses        781     1207      +426     
+ Partials      108       60       -48     

Impacted Files	Coverage Δ
core/application/commands.go	71.66% <ø> (+2.70%)	⬆️
infrastructure/network/network_service.go	0.00% <0.00%> (ø)
pkg/planner/actuator.go	86.20% <ø> (ø)
pkg/validation/validate.go	100.00% <ø> (+12.50%)	⬆️
core/plans/microvm_create_update.go	57.53% <36.36%> (+2.65%)	⬆️
infrastructure/network/errors.go	50.00% <50.00%> (ø)
core/steps/network/interface_delete.go	90.90% <73.33%> (-9.10%)	⬇️
core/steps/network/interface_create.go	93.22% <75.00%> (-3.08%)	⬇️
infrastructure/network/utils.go	76.92% <76.92%> (ø)
core/plans/microvm_delete.go	60.00% <83.33%> (+3.13%)	⬆️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb613ae...9efcd18. Read the comment docs.