feat: add developer docs #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 55.81% 53.66% -2.15%
==========================================
Files 44 46 +2
Lines 2012 2139 +127
==========================================
+ Hits 1123 1148 +25
- Misses 781 885 +104
+ Partials 108 106 -2
Continue to review full report at Codecov.
|
Callisto13
added
kind/documentation
yitsushi
reviewed
Nov 9, 2021
Callisto13
force-pushed
the
dev-docs
branch
2 times, most recently
from
bb70ef2 to
88c0af1
Compare
Skarlso
reviewed
Nov 9, 2021
Callisto13
force-pushed
the
dev-docs
branch
2 times, most recently
from
56833be to
9301380
Compare
richardcase
reviewed
Nov 10, 2021
Callisto13
force-pushed
the
dev-docs
branch
2 times, most recently
from
f6e8852 to
0c14982
Compare
yitsushi
approved these changes
Nov 10, 2021
richardcase
approved these changes
Nov 10, 2021
| Every issue will be assigned a `priority/<x>` label. The levels of priorities are: | ||
|
|
||
| - [`critical-urgent`](https://github.com/weaveworks/flintlock/labels/priority%2Fcritical-urgent): These are time sensitive issues which should be picked up immediately. | ||
| If an issue labelled `critical` is not assigned or being actively worked on, |
There was a problem hiding this comment.
nit, maybe in this block all instances of cirtical could be changed to critical-urgent. But thats being a bit pedantic i feel.
There was a problem hiding this comment.
oops sorry just saw this 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shiny new contrib docs!
What copy-paste? Who said anything about copy-paste? I will not stand for these accusations! (does it make it better if i copied from my past self?)
Might be easier to read fully rendered.
I have added our latest ADR process too (per slack discussion).
Can tweak anything 👍
There is a TODO (testing standards) but I will add that later as i would like to have a discussion around it first.