-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: initial repo setup #21
Conversation
Signed-off-by: Richard Case <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me !
.github/workflows/titlecheck.yml
Outdated
uses: aslafy-z/conventional-pr-title-action@master | ||
with: | ||
success-state: Title follows the specification. | ||
failure-state: Title does not follow the specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about linking to the spec, so that folks don't get a "Title does not follow the specification" and then have to work out which specification the PR doesn't follow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea, let me do that
034732c
to
98ec39c
Compare
Signed-off-by: Richard Case <[email protected]>
98ec39c
to
ad4dcf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks for addressing that, it's been one of my annoyances in other projects :-)
Signed-off-by: Richard Case [email protected]
What this PR does / why we need it:
Initial setup of the repo.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes https://github.com/weaveworks/team-quick-silver/issues/39
Special notes for your reviewer:
Checklist:
Release note: