Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: initial repo setup #21

Merged
merged 2 commits into from
Jun 30, 2021
Merged

chore: initial repo setup #21

merged 2 commits into from
Jun 30, 2021

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Jun 28, 2021

Signed-off-by: Richard Case [email protected]

What this PR does / why we need it:

Initial setup of the repo.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes https://github.com/weaveworks/team-quick-silver/issues/39

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Release note:

Initial repo setup

Signed-off-by: Richard Case <[email protected]>
@richardcase richardcase added the kind/feature New feature or request label Jun 28, 2021
@richardcase richardcase marked this pull request as ready for review June 29, 2021 09:31
bigkevmcd
bigkevmcd previously approved these changes Jun 29, 2021
Copy link

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me !

uses: aslafy-z/conventional-pr-title-action@master
with:
success-state: Title follows the specification.
failure-state: Title does not follow the specification.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about linking to the spec, so that folks don't get a "Title does not follow the specification" and then have to work out which specification the PR doesn't follow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, let me do that

Copy link

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks for addressing that, it's been one of my annoyances in other projects :-)

@richardcase richardcase merged commit 97ed3d7 into main Jun 30, 2021
@richardcase richardcase deleted the initial_setup branch June 30, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants