-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial E2E tests [running locally] #187
Conversation
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 54.89% 54.89%
=======================================
Files 45 45
Lines 1991 1991
=======================================
Hits 1093 1093
Misses 791 791
Partials 107 107
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant stuff! Read it twice and the only thing I found was a rogue space
993fcef
to
934db93
Compare
@jmickey updated to include Get and List |
// What it does is compile flintlockd and start containerd and flintlockd. | ||
// So 'TestSetterUpper' did not sound as slick, but that is what it is. | ||
// I am happy for literally any suggestions. | ||
type Runner struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bootstrapper?
Also not coming up with any decent ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is more coming to it soon, so maybe inspiration will strike
sorry i had to re-push + dismiss bc apparently my last commit was not signed 🤦♀️ |
oh ffs |
LOL and now none of them have it |
The long awaited E2E tests!! Will they live up to the hype?!
Probably not since this is only a small piece from a long list and there is no guarantee whatsoever that they will work for anyone else.
This PR adds:
This PR removes:
This PR does not:
This is just the initial bit to get us by, so much will change, for instance:
Right now there are various placeholder checks inDonetest/e2e/e2e_test.go
which ensure a mVM has started. This was just until the Get was merged, so I am actually gonna replace that right now this second.entrypoint
script and run on container start. This is very finicky when it comes to tearing down, so I am going to move that into the test itself. (Balazs it was thetrap
bit which was irritating me earlier. Like always the option you choose to be a shortcut is the most time consuming.)test/e2e/utils/runner.go
), so please suggest whatever.bootstrap.sh
script. I might change it because this is kindof useful and also kindof not./dev
and share theipc
namespace .....Coming soon to a test suite near you:
these are all in various states of preparedness and idk which order they will appear in