Ability to query older versions of a vmspec #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
reviewed
Oct 29, 2021
yitsushi
force-pushed
the
spec-get-older-versions
branch
from
ccc98a4 to
062c1ad
Compare
I tried to come up with a proper solution to this, but all of them had flaws. == Options I found and explored their possibilities 1. Add a new version argument to the Get function. That's just ugly as hell. I like the Options pattern. Much easier to update without breaking 300 calls in the codebase. 2. Add a new function on the Repo. It seems odd and I think it's unnecessary because Get can handle it. 3. Create a function only on the Containerd repo implementation. That would require checks and casting everywhere we want to use it. == Conclusion I picked options 1, because it causes less pain not and long term. It does not matter what content store we are using, it HAS to be able to manage versions somehow, even if it's an external service, the Repository implementation has to handle versions, without versions we are are playing with a bag of venomous snakes without any kind of antidote, maybe fun, but not safe. Related to liquidmetal-dev#66
yitsushi
force-pushed
the
spec-get-older-versions
branch
from
062c1ad to
428b933
Compare
yitsushi
commented
Nov 2, 2021
Comment on lines
-62
to
-64
| exists, err = repo.Exists(ctx, testOwnerName, testOwnerNamespace) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(exists).To(BeFalse()) |
There was a problem hiding this comment.
Removed because it was a duplication, the previous 3 lines are exactly the same, and couldn't figure out what else does it want to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With this change set, we can query older versions of a spec. We need this for update and update validation.
Which issue(s) this PR fixes:
Related to #66
Special notes for your reviewer:
I tried to come up with a proper solution to this, but all of them had
flaws.
== Options I found and explored their possibilities
That's just ugly as hell. I like the Options pattern. Much easier to
update without breaking 300 calls in the codebase.
It seems odd and I think it's unnecessary because Get can handle it.
That would require checks and casting everywhere we want to use it.
== Conclusion
I picked options 1, because it causes less pain not and long term.
It does not matter what content store we are using, it HAS to be able
to manage versions somehow, even if it's an external service, the
Repository implementation has to handle versions, without versions
we are are playing with a bag of venomous snakes without any kind of
antidote, maybe fun, but not safe.
Checklist: