feat: add list microvm api implementation #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmickey
added
kind/feature
yitsushi
reviewed
Oct 27, 2021
|
@yitsushi Yes, of course. Sorry forgot 😬 |
richardcase
reviewed
Oct 27, 2021
| logger := log.GetLogger(ctx).WithField("component", "app") | ||
| logger.Trace("querying all microvms in namespace: ", namespace) | ||
|
|
||
| if namespace == "" { |
There was a problem hiding this comment.
Do you think there will every be a scenario that we want to list all microVMs irrespective of namespace? At this stage, i'm not sure there is that need.
|
Merged this with #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add the implementation for listing all MicroVMs in a given namespace.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #72
Checklist: