ci: ensure nightly builds actually runs #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
force-pushed
the
fix-e2e
branch
5 times, most recently
from
557d19c to
286421c
Compare
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 40.09% 39.47% -0.63%
==========================================
Files 32 32
Lines 1444 1477 +33
==========================================
+ Hits 579 583 +4
- Misses 789 818 +29
Partials 76 76
Continue to review full report at Codecov.
|
Callisto13
force-pushed
the
fix-e2e
branch
5 times, most recently
from
0e45af8 to
f527e32
Compare
Callisto13
changed the title
Callisto13
force-pushed
the
fix-e2e
branch
2 times, most recently
from
5fb2c87 to
493c88f
Compare
richardcase
previously approved these changes
Oct 17, 2021
|
ffs i swear those commits were signed when i pushed them |
- ensure TF metal create works - cleanup projects after e2e run - use the correct format for the terraform action - ensure TF outputs are correctly formatted. The TF wrapper included in the action manipulates stdout and stderr to make it compatible with use in action pipelines, but that unfortunately makes it a pain to work with if you are using the output elsewhere.
richardcase
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the e2e nightlies, it appears they never actually had a successful run.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #127