Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add kvm install and config to vagrantfile #133

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

jmickey
Copy link
Contributor

@jmickey jmickey commented Oct 12, 2021

What this PR does / why we need it:

Vagrant environment was missing the installation for KVM, which is required for Firecracker to work. I added it manually to my environment last week but forgot to add it to the Vagrantfile.

@jmickey jmickey added the kind/cleanup Removing things previously overlooked label Oct 12, 2021
@jmickey jmickey self-assigned this Oct 12, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #133 (924c130) into main (12b503c) will increase coverage by 0.16%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
+ Coverage   40.09%   40.26%   +0.16%     
==========================================
  Files          32       32              
  Lines        1444     1448       +4     
==========================================
+ Hits          579      583       +4     
  Misses        789      789              
  Partials       76       76              
Impacted Files Coverage Δ
core/application/commands.go 64.93% <83.33%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d0f857...924c130. Read the comment docs.

richardcase
richardcase previously approved these changes Oct 12, 2021
Copy link
Member

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmickey
Copy link
Contributor Author

jmickey commented Oct 12, 2021

@richardcase I had to repush the commit because I don't have commit signing enabled on the VM. It automatically dismissed your review.

@jmickey jmickey merged commit de226ea into main Oct 12, 2021
@jmickey jmickey deleted the chore/add-kvm-vagrant branch October 12, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted kind/cleanup Removing things previously overlooked size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants