-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add vagrant configuration with complete dev environment #123
Conversation
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage 40.09% 40.09%
=======================================
Files 32 32
Lines 1444 1444
=======================================
Hits 579 579
Misses 789 789
Partials 76 76 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Manual testing
- The selected box does not support libvirt
config.vm.provider :libvirt do |libvirt|
libvirt.connect_via_ssh = false
libvirt.username = "root"
libvirt.storage_pool_name = "vagrant"
end
- Installed vbox
- Tried to do with vbox (
vagrant up --provider=virtualbox
) - The virtual machine did not boot (vagrant timeout)
checked with the vbox gui, something: invalid settings for graphics controller - I assume it's working on mac ;)
Vagrantfile
Outdated
v.memory = 4096 | ||
v.cpus = 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one might be low later on, it's good now, but when we are creating 3 MicroVMs and configuring ak8s cluster on them, that 2 vpcu will be low and I think memory too.
Now it's fine, we can update later, just wanted mention it.
Updated the PR description with Somehow the checker still does not see the code-block:
@jmickey: can you try to force-push to the branch, maybe it can invalidate the cache. I assume it's cached and that's why it cries. |
686b095
to
45756bc
Compare
@yitsushi I added a |
45756bc
to
1c77729
Compare
@jmickey : I tried with my own snippet above, but the issue is the selected box does not support libvirt
and I don't think there is a real value to add it and later hear "it's in there, but does not work, fix it"
|
Ah right you are. I can switch it to |
1c77729
to
c7d9265
Compare
@yitsushi Switched to a ubuntu box that has |
* Force libvirt to use NFS driver for the shared folder. It will install all necessary tools for it. If they are not installed it will use rsync for shared folders as a fallback, which is not bidirectional. * On re-provisioning, unzip because it does not know what to do if the file is already there. Error: ``` default: replace /usr/local/bin/firecracker? [y]es, [n]o, [A]ll, [N]one, [r]ename: NULL default: (EOF or read error, treating as "[N]one" ...) ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual test
- Changed storage pool name, because I use kvm for other things too, and with default it has conflicts, but that does not matter
vagrant up
- Everything is working
Added commit: see commit message
What this PR does / why we need it:
PR adds a few things.
containerd
configuration.vagrant
folder to gitignoreRelease note: