docs: basic structure for README.md and CONTRIBUTING.md #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 40.09% 40.26% +0.16%
==========================================
Files 32 32
Lines 1444 1448 +4
==========================================
+ Hits 579 583 +4
Misses 789 789
Partials 76 76
Continue to review full report at Codecov.
|
yitsushi
force-pushed
the
82-create-readme
branch
2 times, most recently
from
a03a7ea to
9569064
Compare
yitsushi
force-pushed
the
82-create-readme
branch
from
9569064 to
1225f95
Compare
* Add README.md * Add CONTRIBUTING.md fixes liquidmetal-dev#82
yitsushi
force-pushed
the
82-create-readme
branch
from
1225f95 to
f8840c7
Compare
jmickey
reviewed
Oct 8, 2021
jmickey
previously approved these changes
Oct 8, 2021
There was a problem hiding this comment.
LGTM. @richardcase might have some more suggestions, but this seems like a good start!
yitsushi
commented
Oct 8, 2021
README.md
Outdated
|
|
||
| * Companies that want to use Kubernetes, but they are tied to their physical | ||
| servers for technical or legal reasons. | ||
| * ??? |
There was a problem hiding this comment.
I'm pretty sure it's not done yet XD
Callisto13
reviewed
Oct 12, 2021
Same changes can be submitted to weaveworks/ignite as I copied a lot of stuff from there. Co-authored-by: Claudia <[email protected]>
Co-authored-by: Claudia <[email protected]>
Signed-off-by: Richard Case <[email protected]>
richardcase
force-pushed
the
82-create-readme
branch
from
c7c0102 to
60f32d1
Compare
richardcase
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We currently have a blank README.md file. We need to change this and provide information about the project and also how to contribute.
Which issue(s) this PR fixes
Fixes #82
Special notes for your reviewer:
Checklist:
Release note: