Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bridge networking mode #128

Closed
richardcase opened this issue Oct 11, 2021 · 11 comments
Closed

Support bridge networking mode #128

richardcase opened this issue Oct 11, 2021 · 11 comments
Labels
area/api Indicates an issue or PR relates to the APIs area/firecracker Indicates an issue or PR related to Firecracker kind/documentation Documentation only kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@richardcase
Copy link
Member

richardcase commented Oct 11, 2021 •
edited
Loading

Describe the solution you'd like:
The initial use case is for the primary network interface to use macvtap. However, we should support a tap interface being attached to an existing bridge.

If we are to support this then we may want to consider:

  • Creating a new flag that tells reignite to run in macvtap mode or bridge mode for the main interface. I think it should be either but not both.
  • If in bridge mode then a tap interface for the main adapter should be attached to the bridge.
  • What do you about IP tables? Assume they have been created already.

In the poc we also had setup code that you ran once to setup a bridge/iptables. I don't thinkw e need this at this stage as it could be covered by documentation.

Anything else you would like to add:

We need a design session around this.
@richardcase richardcase added kind/documentation Documentation only kind/feature New feature or request area/api Indicates an issue or PR relates to the APIs area/firecracker Indicates an issue or PR related to Firecracker labels Oct 11, 2021
yitsushi added a commit to yitsushi/flintlock that referenced this issue Oct 12, 2021
@yitsushi
Document how to set up network with wireless adapter
c6b0dec 
This is working with wired or wireless adapters. For wired, it's not
necessary because macvtap can do the trick, but it has issues with
wireless adapters.

The whole quick-start document tries to set up a well separated
environment with reignite specific containerd configuration, thinpool
location. Based on this logic the networking setup follows the same
principles.

This is an issue only with wireless adapters, so this is completely
linux specific as VirtualBox machines have as "wired" connection.
Because of this simple reason, the documentation utilize virsh to create
a network with all the required bridge configuration and iptables rules.

related to liquidmetal-dev#128
@yitsushi yitsushi mentioned this issue Oct 12, 2021
Merged
2 tasks
yitsushi added a commit that referenced this issue Oct 20, 2021
@yitsushi
Document how to set up networking with wireless adapter (#135)
3cc5c47 
* Document how to set up network with wireless adapter

This is working with wired or wireless adapters. For wired, it's not
necessary because macvtap can do the trick, but it has issues with
wireless adapters.

The whole quick-start document tries to set up a well separated
environment with reignite specific containerd configuration, thinpool
location. Based on this logic the networking setup follows the same
principles.

This is an issue only with wireless adapters, so this is completely
linux specific as VirtualBox machines have as "wired" connection.
Because of this simple reason, the documentation utilize virsh to create
a network with all the required bridge configuration and iptables rules.

related to #128

* Change wording

It was hard to follow/understand, it looks much better now.

References:
* #135 (comment)
@richardcase richardcase added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Nov 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2022
@richardcase
Copy link
Member Author

@yitsushi - what else do you think we need for this? If anything?

@yitsushi
Copy link
Contributor

Good question. I don't know. I still can't configure a vm with bridge.

Manually set master and assign IP:

❯ sudo ip link set fltap0991727 master rgntbr0
❯ sudo ip addr add 192.168.100.30/24 dev fltap0991727

IP on guest machine:

[   15.525004] cloud-init[687]: Cloud-init v. 21.2-3-g899bfaa9-0ubuntu2~18.04.1 running 'init' at Mon, 10 Jan 2022 09:55:41 +0000. Up 5.33 seconds.
[   15.526179] cloud-init[687]: ci-info: ++++++++++++++++++++++++++++++++++++++++Net device info++++++++++++++++++++++++++++++++++++++++
[   15.526719] cloud-init[687]: ci-info: +--------+------+------------------------------+-----------------+--------+-------------------+
[   15.527220] cloud-init[687]: ci-info: | Device |  Up  |           Address            |       Mask      | Scope  |     Hw-Address    |
[   15.527717] cloud-init[687]: ci-info: +--------+------+------------------------------+-----------------+--------+-------------------+
[   15.528228] cloud-init[687]: ci-info: |  eth0  | True |         169.254.0.1          |   255.255.0.0   | global | aa:ff:00:00:00:01 |
[   15.528728] cloud-init[687]: ci-info: |  eth0  | True |   fe80::a8ff:ff:fe00:1/64    |        .        |  link  | aa:ff:00:00:00:01 |
[   15.529264] cloud-init[687]: ci-info: |  eth1  | True |        192.168.100.30        | 255.255.255.255 | global | 5e:df:22:8c:1b:dd |
[   15.529786] cloud-init[687]: ci-info: |  eth1  | True | fe80::5cdf:22ff:fe8c:1bdd/64 |        .        |  link  | 5e:df:22:8c:1b:dd |
[   15.530284] cloud-init[687]: ci-info: |   lo   | True |          127.0.0.1           |    255.0.0.0    |  host  |         .         |
[   15.530783] cloud-init[687]: ci-info: |   lo   | True |           ::1/128            |        .        |  host  |         .         |
[   15.531339] cloud-init[687]: ci-info: +--------+------+------------------------------+-----------------+--------+-------------------+

But still can't reach on ssh:

❯ ssh 192.168.100.30
ssh: connect to host 192.168.100.30 port 22: Connection refused

Potential addition:

  • If tap, set master

@richardcase
Copy link
Member Author

Ok lets keep this open then.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 11, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2022
@Callisto13 Callisto13 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
@yitsushi
Copy link
Contributor

Still valid.

@Callisto13
Copy link
Member

I think this was added late last year #479

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 20, 2023
@yitsushi
Copy link
Contributor

Hmm, I assume it's fixed then. @richardcase ?

@richardcase
Copy link
Member Author

@yitsushi @Callisto13 - we could treat this as fixed, if we assume that something else like virsh is used to create the bridge and along with it the ip tables.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 5, 2023
@yitsushi yitsushi closed this as completed Aug 7, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Closed in Liquid Metal Roadmap - Public Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api Indicates an issue or PR relates to the APIs area/firecracker Indicates an issue or PR related to Firecracker kind/documentation Documentation only kind/feature New feature or request lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
No open projects
Liquid Metal Roadmap - Public
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yitsushi @richardcase @Callisto13