Stop hard failing resync on boot

If one fails, we can still listen on new requests and reconcile vms, if they are failing always, the retry logic will handle this.
liquidmetal-dev · Nov 15, 2021 · e48e1d7 · e48e1d7
1 parent e1c3626
commit e48e1d7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/core/steps/microvm/start.go b/core/steps/microvm/start.go
@@ -14,7 +14,7 @@ import (
 	"github.com/weaveworks/flintlock/pkg/planner"
 )
 
-const waitToBoot = 10
+const waitToBoot = 5
 
 func NewStartStep(vm *models.MicroVM, vmSvc ports.MicroVMService) planner.Procedure {
 	return &startStep{

diff --git a/infrastructure/controllers/microvm_controller.go b/infrastructure/controllers/microvm_controller.go
@@ -48,7 +48,10 @@ func (r *MicroVMController) Run(ctx context.Context,
 
 	if resyncOnStart {
 		if err := r.resyncSpecs(ctx, logger); err != nil {
-			return fmt.Errorf("resyncing specs on start: %w", err)
+			// Do not return here, if one fails, we can still listen on
+			// new requests and reconcile vms, if they are failing always,
+			// the retry logic will handle this.
+			logger.Errorf("resyncing specs on start: %s", err.Error())
 		}
 	}