Skip to content

Commit

Permalink
Stop hard failing resync on boot
Browse files Browse the repository at this point in the history
If one fails, we can still listen on new requests and reconcile vms, if
they are failing always, the retry logic will handle this.
  • Loading branch information
yitsushi committed Nov 15, 2021
1 parent a1bedea commit ae70166
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 52 deletions.
2 changes: 1 addition & 1 deletion core/steps/microvm/start.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
"github.com/weaveworks/flintlock/pkg/planner"
)

const waitToBoot = 10
const waitToBoot = 5

func NewStartStep(vm *models.MicroVM, vmSvc ports.MicroVMService) planner.Procedure {
return &startStep{
Expand Down
50 changes: 0 additions & 50 deletions hack/scripts/payload/CreateMicroVM.json

This file was deleted.

5 changes: 4 additions & 1 deletion infrastructure/controllers/microvm_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ func (r *MicroVMController) Run(ctx context.Context,

if resyncOnStart {
if err := r.resyncSpecs(ctx, logger); err != nil {
return fmt.Errorf("resyncing specs on start: %w", err)
// Do not return here, if one fails, we can still listen on
// new requests and reconcile vms, if they are failing always,
// the retry logic will handle this.
logger.Errorf("resyncing specs on start: %w", err)
}
}

Expand Down

0 comments on commit ae70166

Please sign in to comment.