Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump Ubuntu and kernel versions for CI builds #57

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

aleksamagicka
Copy link
Member

@aleksamagicka aleksamagicka commented Oct 10, 2023

Just noticed that the kernel versions the CI uses are fairly old. Bump them up to current ones, including the Ubuntu version.


Shouldn't break anything, I hope? Or should I leave the 5.x ones in and only add these new ones?

@amezin
Copy link
Member

amezin commented Oct 10, 2023

I think for kernel versions we should have at least:

  • master
  • oldest version that we support (I guess it's 5.10)

5.15 was just the latest stable version at the time the pipeline was added. Maybe it would make sense to track the latest stable release (for the case when master is broken, for example).

For Ubuntu versions - maybe just set them to ubuntu-latest everywhere and forget?

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@jonasmalacofilho jonasmalacofilho merged commit 264c218 into liquidctl:master Oct 11, 2023
11 checks passed
@aleksamagicka aleksamagicka deleted the ci-bump-kernel branch October 13, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants