Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert bucket names to random UUID for security #173

Merged
merged 25 commits into from
May 3, 2024

Conversation

zanerock
Copy link
Member

@zanerock zanerock commented May 3, 2024

Pull request to:

Submitted by: zanerock

Instructions

Review all code changes. Verify the submitter attestations belowe, checking off each statement to indicate that you have reviewed the statement and it is true to the best of your knowledge. If you do not agree with or are unsure of a statement, then add a comment describing your questions or concerns and contact the submitter @zanerock for clarification.

QA files

Submitter attestations

To be verified by reviewer.

  • Do the changes implement all concrete TODOs in the change ticket? y (WORK_SUBMIT_IMPLEMENT_ALL_TODOS=true)
  • Are there other changes not described in the original work description? n (WORK_SUBMIT_HAS_ADDITIONAL_CHANGES=false)
  • Do the changes add or involve connections, authentication, or queries to a database or any third-party service? n (WORK_SUBMIT_THIRD_PARTY_SERVICES_MODIFIED=false)
  • Has all debug, hard coded test data, and hard coded authentication data been removed? y (WORK_SUBMIT_DEBUG_REMOVED=true)
  • I have reviewed and verified the above are true to the best of my knowledge.

zanerock added 25 commits May 1, 2024 16:00
…cket' to site (instead of plugins); added tags to buckets since we can't discriminate on names anymore
@zanerock zanerock added this to the 1.0.0-rc milestone May 3, 2024
@zanerock zanerock self-assigned this May 3, 2024
@zanerock zanerock merged commit 899c9d3 into liquid-labs:main May 3, 2024
1 check passed
@zanerock zanerock deleted the work-liquid-labs/cloudsite/169 branch May 3, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment