Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAT-14184] Add index.htm file to xsd schemes page #364

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

vitaliimak
Copy link

No description provided.

Copy link

@KushnirykOleh KushnirykOleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we aren't going to created new schema file for every mongo release, this logic differs from liquibase-core logic to form a list of entries. I would like @jnewton03 and @jandroav review it, so they can think of any unwanted complications this might bring in future that we aren't aware of or anything to do differently. As for me it looks good

@KushnirykOleh KushnirykOleh requested a review from jnewton03 May 11, 2023 10:38
Copy link

@jandroav jandroav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitaliimak vitaliimak merged commit 1439b1e into main May 15, 2023
@vitaliimak vitaliimak deleted the DAT-14184 branch May 15, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants