Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an 'author' argument for the DiffChangelogCommand #132

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

EggOxygen
Copy link

This PR introduces an 'author' argument to support the diff-changelog command in liquibase/liquibase#3990.

I tested it on a Gradle-based project and ran diffChangelog. The changesets' author appears to be functioning correctly with the one I provided.

@MalloD12 MalloD12 self-assigned this Sep 21, 2023
@MalloD12 MalloD12 self-requested a review September 25, 2023 11:57
Copy link

@MalloD12 MalloD12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Review and testing results:

Code looks good to me. I could also see author is being set correctly in the generated changelog.

Things to be aware of:

  • None

Things to worry about:

  • None

@filipelautert filipelautert merged commit a0799fd into liquibase:master Sep 25, 2023
@stevesaliman
Copy link
Collaborator

I added the author argument to GenerateChangeLogCommand since that command also supports it in Liquibase.

I also updated the changelog, changed the version to a SNAPSHOT version, and made the order of constants more consistent with the others.

@unlimitedsola
Copy link

Thanks to everyone who worked on this! Can we get a new version released for this?

We have a custom Gradle setup where we wanted to use the contributor's Git username as the author to generate changelogs and we're excited about this to be fixed.

@MalloD12
Copy link

cc: @stevesaliman ^^

@stevesaliman
Copy link
Collaborator

I had some other things I had hoped to fix in the next release, but I'm not sure if I'll be able to. I can do a release for this fix over the weekend.

@unlimitedsola
Copy link

@stevesaliman Sorry for bothering you again, is there anything that we can help with to get a new version released?

@stevesaliman
Copy link
Collaborator

Version 2.2.1 was released this morning. Sorry for the delay.

@unlimitedsola
Copy link

❤️ Thanks for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants