[DAT-18260] Add tblProperties to createView #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelautert
force-pushed
the
DAT-18260
branch
from
0b8a1e4 to
60d0622
Compare
|
SvampX
approved these changes
Sep 13, 2024
|
|
||
| @Override | ||
| public boolean supports(CreateViewStatement statement, Database database) { | ||
| return super.supports(statement, database) && (database instanceof DatabricksDatabase); |
There was a problem hiding this comment.
We might check instanceof first, because boolean statements with double signs like '&&' are "fail fast" and if DB is inapropriate there won't be a call to super.
I'm not sure if my propose makes sence in readability perspective though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.