Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the snowflake-jdbc driver to 3.13.1 #54

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

girimathi
Copy link
Contributor

The older version of the snowflake-jdbc-3.12.3 driver version introduced theIllegal reflective access warningmentioned in this issue# snowflakedb/snowflake-jdbc#202. The updated snowflake-jdbc-3.13.1.jar version fixing the issue as tested in our environment.

Test job ran with the default liquibase latest container getting the error :

Screen Shot 2021-03-22 at 5 29 24 PM

The same test job ran with the local liquibase container with an updated snowflake-jdbc-3.13.1.jar

Screen Shot 2021-03-22 at 5 32 41 PM

Local docker file

Screen Shot 2021-03-22 at 5 35 00 PM

The older version of the snowflake-jdbc-3.12.3 driver version introduced the Illegal reflective access mentioned in this issue# snowflakedb/snowflake-jdbc#202. The updated snowflake-jdbc-3.13.1.jar version fixing the issue as tested in our environment.
@girimathi
Copy link
Contributor Author

Hi Liquibase team,

Please let me know when can expect this Pull request review?

Copy link
Contributor

@r2-lf r2-lf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the new SHA1 for the 13.1 snowflake driver. Can you update line 66 please?

Thanks!

@girimathi
Copy link
Contributor Author

Thanks for your review.
I updated the SNOWFLAKE_SHA1 to snowflake-jdbc-3.13.1.jar driver
reference :
https://repo1.maven.org/maven2/net/snowflake/snowflake-jdbc/3.13.1/snowflake-jdbc-3.13.1.jar.sha1

@r2-lf
Copy link
Contributor

r2-lf commented Mar 26, 2021

You are the BEST! Thanks!

@r2-lf r2-lf merged commit 946cc1c into liquibase:main Mar 26, 2021
@r2-lf
Copy link
Contributor

r2-lf commented Mar 26, 2021

This will be latest in Docker hub. When we do another Liquibase release, it will be tagged appropriately. Thanks again!

@girimathi
Copy link
Contributor Author

Great, thanks for the approval and merge.
do you have the release date to get the latest tagged version with this update?

@r2-lf
Copy link
Contributor

r2-lf commented Mar 30, 2021

Thank YOU @girimathi . Shouild be already out and tagged as latest. Is it not? You should just get it with docker run liquibase/liquibase. Let me know if that's not the case!

@girimathi
Copy link
Contributor Author

yes, the latest tagged liquibase container having the update and fixed the issues.
Thank you for your response.

@r2-lf
Copy link
Contributor

r2-lf commented Mar 31, 2021

Awesome! Thank YOU!

@lgadawski
Copy link

lgadawski commented Apr 2, 2021

Could we also include liquibase-snowflake-4.3.2.jar into docker image? I think it's needed to have Snwoflake connection fully working. Without that it is failing on my instance. I could even prepare merge request for that but https://github.com/liquibase/liquibase-snowflake/releases doesn't share SHA1 value.

@r2-lf
Copy link
Contributor

r2-lf commented Apr 5, 2021

Hi, @lgadawski ! You just need to download the jar file from maven central and run sha1sum on it to get the hash.

Happy to merge the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants