Skip to content

Commit

Permalink
fix(workflows): update conditionals in extension-attach-artifact-rele…
Browse files Browse the repository at this point in the history
…ase.yml, os-extension-test.yml, pro-extension-test.yml, and sonar-test-scan.yml to use 'inputs' instead of 'github.event.inputs' for improved readability and consistency.
  • Loading branch information
jandroav committed Sep 4, 2023
1 parent a819699 commit 2d078a9
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/extension-attach-artifact-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,13 @@ jobs:
ASSET_DIR: ./target

- name: Get upload_zip.sh Script File
if: github.event.inputs.zip == 'true'
if: inputs.zip == 'true'
run: |
curl -o $PWD/.github/upload_zip.sh https://raw.githubusercontent.com/liquibase/build-logic/v0.3.9/.github/upload_zip.sh
chmod +x $PWD/.github/upload_zip.sh
- name: Attach Zip File to Draft Release
if: github.event.inputs.zip == 'true'
if: inputs.zip == 'true'
id: upload-release-zip
run: ./.github/upload_zip.sh $(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/os-extension-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ jobs:
strategy:
fail-fast: false
matrix:
java: ${{fromJson(github.event.inputs.java || '[8, 11, 17, 18]')}}
os: ${{fromJson(github.event.inputs.os || '["ubuntu-latest", "windows-latest"]')}}
java: ${{fromJson(inputs.java || '[8, 11, 17, 18]')}}
os: ${{fromJson(inputs.os || '["ubuntu-latest", "windows-latest"]')}}
name: Test Java ${{ matrix.java }} - ${{ matrix.os }}
runs-on: ${{ matrix.os }}
needs: build
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pro-extension-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ jobs:
strategy:
fail-fast: false
matrix:
java: ${{fromJson(github.event.inputs.java || '[8, 11, 17, 18]')}}
os: ${{fromJson(github.event.inputs.os || '["ubuntu-latest", "windows-latest"]')}}
java: ${{fromJson(inputs.java || '[8, 11, 17, 18]')}}
os: ${{fromJson(inputs.os || '["ubuntu-latest", "windows-latest"]')}}
name: Test Java ${{ matrix.java }} - ${{ matrix.os }}
runs-on: ${{ matrix.os }}
needs: build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sonar-test-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ jobs:
LIQUIBASE_PRO_LICENSE_KEY: ${{ secrets.PRO_LICENSE_KEY }}
run: |
export ORACLE_HOME=$ORACLE_HOME:$HOME/instantclient_21_5; export PATH=$PATH:$HOME/instantclient_21_5; export SQLPATH=$HOME/instantclient_21_5; export NLS_LANG=AMERICAN_AMERICA.UTF8; export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$HOME/instantclient_21_5
./mvnd/bin/mvnd -B clean verify sonar:sonar \
./mvnd/bin/mvnd -B clean verify sonar:sonar -P 'testAll,!run-proguard' \
"${{ inputs.mavenArgs }}" \
"-Dliquibase.version=${{ inputs.liquibaseBranchName }}-SNAPSHOT" \
"-Dbuild.pro.number=${{ github.run_number }}" \
Expand Down

0 comments on commit 2d078a9

Please sign in to comment.