-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add declarative peering section #2813
base: master
Are you sure you want to change the base?
Conversation
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
64eee72
to
c334f63
Compare
c334f63
to
ee2231d
Compare
|
||
## Declarative configuration of namespace offloading | ||
|
||
While offloading is independent from the network, which means that it is possible to negotiate resources and configure a namespace offloading without the inter-cluster network enabled, **a [working authentication configuration](#declarative-configuration-of-clusters-authentication) is a pre-requisite to enable offloading**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While offloading is independent from the network, which means that it is possible to negotiate resources and configure a namespace offloading without the inter-cluster network enabled, **a [working authentication configuration](#declarative-configuration-of-clusters-authentication) is a pre-requisite to enable offloading**. | |
While offloading is independent from the network, which means that it is possible to negotiate resources and configure a namespace offloading without the inter-cluster network enabled (either because it is not needed, or because is provided by a third-party mechanism), **a [working authentication configuration](#declarative-configuration-of-clusters-authentication) is instead a mandatory pre-requisite**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there might be cases in which inter-cluster network is actually not required (e.g. I need to offload some pods that do not require to "talk" with pods or services on the local cluster).
Maybe we can add a section somewhere (like in manual peering) where we explain the inter-dependency between the modules, and here add reference to that section.
Explaing everything here seems a little out of context to me, as I just wanted to say: "do not proceed with this guide if you didn't configure the authentication module"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Modified accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me.
Minor comments, mainly small rephrasing.
f4b8613
to
142d250
Compare
ecb60ad
to
bbbc4f8
Compare
Description
This PR add the documentation for the creation of peerings via a declarative approach, by applying CRs.
How Has This Been Tested?
N/A