liqoctl: add identity command #2216
Draft
+42,794
−1,350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aleoli. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
force-pushed
the
network-external
branch
2 times, most recently
from
c281dd6
to
3c6ccec
Compare
aleoli
force-pushed
the
aol/liqoctl-ideneity
branch
3 times, most recently
from
6ea7c08
to
ee112fe
Compare
aleoli
force-pushed
the
network-external
branch
from
ab6cc4e
to
3ff8a74
Compare
cheina97
force-pushed
the
aol/liqoctl-ideneity
branch
from
ee112fe
to
28b1d7e
Compare
cheina97
approved these changes
Jan 3, 2024
Comment on lines
+34
to
+54
| // output implements the logic to output the generated Configuration resource. | ||
| func (o *Options) output(conf *corev1.Secret) error { | ||
| var outputFormat string | ||
| switch { | ||
| case o.generateOptions != nil: | ||
| outputFormat = o.generateOptions.OutputFormat | ||
| default: | ||
| return fmt.Errorf("unable to determine output format") | ||
| } | ||
| var printer printers.ResourcePrinter | ||
| switch outputFormat { | ||
| case yamlLabel: | ||
| printer = &printers.YAMLPrinter{} | ||
| case jsonLabel: | ||
| printer = &printers.JSONPrinter{} | ||
| default: | ||
| return fmt.Errorf("unsupported output format %q", outputFormat) | ||
| } | ||
|
|
||
| return printer.PrintObj(conf, os.Stdout) | ||
| } |
There was a problem hiding this comment.
This should be moved in generate.go or types.go
aleoli
force-pushed
the
network-external
branch
from
9332f58
to
bc50dc7
Compare
aleoli
force-pushed
the
network-external
branch
from
3485350
to
2ab14ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr implements the
generateand theupdateAPIs for certificate rotation. It also restarts pods that are using the certificate.Now, you can use the
liqoctl generate identitycommand on a cluster and apply the output to the other one.Note: if the certificate is expired you probably need to update certificates in both directions (applying this couple of commands twice, starting from different clusters)
How Has This Been Tested?