Warnings on missing .create()

Cargo.toml

@@ -28,6 +28,10 @@ log = "0.4.6"
 percent-encoding = "2.1.0"
 assert-json-diff = "1.0.3"
 
+[dev-dependencies]
+env_logger = "*"
+testing_logger = "0.1"
+
 [features]
 default = ["color"]
 color = ["colored"]

src/lib.rs

@@ -739,6 +739,9 @@ pub struct Mock {
     expected_hits_at_least: Option<usize>,
     expected_hits_at_most: Option<usize>,
     is_remote: bool,
+
+    /// Used to warn of mocks missing a `.create()` call. See issue #112
+    created: bool,
 }
 
 impl Mock {
@@ -754,6 +757,7 @@ impl Mock {
             expected_hits_at_least: None,
             expected_hits_at_most: None,
             is_remote: false,
+            created: false,
         }
     }
 
@@ -1064,20 +1068,21 @@ impl Mock {
     /// let _m = mock("GET", "/").with_body("hello world").create();
     /// ```
     ///
-    pub fn create(self) -> Self {
+    #[must_use]
+    pub fn create(mut self) -> Self {
         server::try_start();
 
         // Ensures Mockito tests are run sequentially.
         LOCAL_TEST_MUTEX.with(|_| {});
 
         let mut state = server::STATE.lock().unwrap();
 
+        self.created = true;
+
         let mut remote_mock = self.clone();
         remote_mock.is_remote = true;
         state.mocks.push(remote_mock);
 
-        debug!("Mock::create() called for {}", self);
-
         self
     }
 
@@ -1097,6 +1102,10 @@ impl Drop for Mock {
             }
 
             debug!("Mock::drop() called for {}", self);
+
+            if !self.created {
+                warn!("Missing .create() call on mock {}", self);
+            }
         }
     }
 }

tests/lib.rs

@@ -1295,3 +1295,43 @@ fn test_default_headers() {
     let (_, headers, _) = request("GET /", "");
     assert_eq!(vec!["connection: close", "content-length: 0"], headers);
 }
+
+#[test]
+fn test_missing_create_bad() {
+    testing_logger::setup();
+
+    let m = mock("GET", "/");
+    drop(m);
+
+    // Expecting one warning
+    testing_logger::validate(|captured_logs| {
+        let warnings = captured_logs
+            .iter()
+            .filter(|c| c.level == log::Level::Warn)
+            .collect::<Vec<&testing_logger::CapturedLog>>();
+
+        assert_eq!(warnings.len(), 1);
+        assert_eq!(
+            warnings[0].body,
+            "Missing .create() call on mock \r\nGET /\r\n"
+        );
+        assert_eq!(warnings[0].level, log::Level::Warn);
+    });
+}
+
+#[test]
+fn test_missing_create_good() {
+    testing_logger::setup();
+
+    let m = mock("GET", "/").create();
+    drop(m);
+
+    // No warnings should occur
+    testing_logger::validate(|captured_logs| {
+        let warnings = captured_logs
+            .iter()
+            .filter(|c| c.level == log::Level::Warn)
+            .collect::<Vec<&testing_logger::CapturedLog>>();
+        assert_eq!(warnings.len(), 0);
+    });
+}