revert: Pull Requests #993 and #985 #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit ed177c6.
Merged
blacha
approved these changes
Jul 8, 2024
dwsilk
approved these changes
Jul 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [4.9.0](v4.8.0...v4.9.0) (2024-07-16) ### Features * Add Shapely type library TDE-1205 ([#988](#988)) ([f5e97e7](f5e97e7)) * use new pull request template ([#999](#999)) ([9a6a0b2](9a6a0b2)) ### Bug Fixes * concurrency file order TDE-1213 ([#998](#998)) ([37dcb8b](37dcb8b)) * Treat item as `dict` TDE-1209 ([#993](#993)) ([384d0fc](384d0fc)) ### Reverts * Pull Requests [#993](#993) and [#985](#985) ([#997](#997)) ([289880c](289880c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Revert Pull Requests #993 and #985
#985 caused collection_from_item to fail and while #985 resolved that issue, it creates invalid STAC Items. Unit tests and GitHub Actions tests did not pick up these issues.
Modification
Revert commits 384d0fc and ed177c6
Checklist
If not applicable, provide explanation of why.