refactor: Reuse dictionary to JSON bytes code TDE-1138 #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0b0
force-pushed
the
refactor/reuse-json-bytes-encoding
branch
from
157ab5a to
09656ec
Compare
Otherwise information will get lost when decoding.
l0b0
force-pushed
the
refactor/reuse-json-bytes-encoding
branch
from
09656ec to
9c266ba
Compare
blacha
approved these changes
May 3, 2024
MDavidson17
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
De-duplicate code. TBD: Determine whether we should
ensure_ascii=Falseeverywhere, based on this discussion.Modification
Centralise JSON encoding code.
Checklist