Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: title & description TDE-955 #835

Merged
merged 3 commits into from
Feb 8, 2024
Merged

refactor: title & description TDE-955 #835

merged 3 commits into from
Feb 8, 2024

Conversation

MDavidson17
Copy link
Contributor

@MDavidson17 MDavidson17 commented Feb 2, 2024

Motivation

refactor title & description formatting to align with naming documentation

Modification

  • docstring updated to point to naming.md
  • event removed from all titles as should now also be included in geographic_description
  • geographic_description removed from elevation description otherwise, if the dataset has an event it will be repeated

Examples:
Hawke's Bay Cyclone Gabrielle 0.3m Rural Aerial Photos (2023)
Ponsonby 0.3m Rural Aerial Photos (2023)

Hawke's Bay Cyclone Gabrielle 0.3m Satellite Imagery (2023)

Auckland LiDAR 0.3m DSM (2023) - Preview

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated - just docstrings
  • Issue linked in Title

@MDavidson17 MDavidson17 marked this pull request as ready for review February 7, 2024 02:47
@MDavidson17 MDavidson17 requested a review from a team as a code owner February 7, 2024 02:47
@MDavidson17 MDavidson17 added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit 94051b8 Feb 8, 2024
1 check passed
@MDavidson17 MDavidson17 deleted the refactor/title branch February 8, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants