fix: NoSuchFileError is stopping multiprocessing sidecar files TDE-1007 #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0b0
reviewed
Jan 31, 2024
l0b0
reviewed
Jan 31, 2024
Co-authored-by: Victor Engmark <[email protected]>
amfage
previously approved these changes
Jan 31, 2024
amfage
approved these changes
Jan 31, 2024
MDavidson17
approved these changes
Jan 31, 2024
l0b0
approved these changes
Feb 1, 2024
paulfouquet
deleted the
fix/nosuchfileerror-stop-multiprocessing-tde-1007
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Downloading sidecar files process currently stop as soon as one of them does not exist, without looking for the others.
Modification
Catch and add the
NoSuchFileErrorto theFutureexception and look for the exceptions once the downloading process (of all sidecar files) is completed, rather than stopping it as soon as one exception is raised.Checklist
If not applicable, provide explanation of why.