Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add new fields to the Collection TDE-985 #765

Merged

Conversation

paulfouquet
Copy link
Collaborator

@paulfouquet paulfouquet commented Dec 5, 2023

Motivation

Giving more details to the data consumers about the dataset.

Modification

Along with recently added arguments to the Collection creation, some new ones have been added (optional and mandatory).
Also simplify the data category management (Enum to Dict).
A Pull Request on https://github.com/linz/topo-workflows/ is coming to pass the new fields from Argo Workflows.
Notes:

Example:

{
  "type": "Collection",
  "stac_version": "1.0.0",
  "id": "01HGF4RAQSM53Z26Y7C27T1GMB",
  "title": "Manawatū-Whanganui 0.3m Storm Satellite Imagery (2024) - Preview",
  "description": "Satellite imagery within the Manawatū-Whanganui region captured in 2024, published as a record of the Storm event.",
  "license": "CC-BY-4.0",
  "links": [
    { "rel": "self", "href": "./collection.json", "type": "application/json" },
    {
      "rel": "item",
      "href": "./BA34_1000_3040.json",
      "type": "application/json"
    },
    {
      "rel": "item",
      "href": "./BA34_1000_3041.json",
      "type": "application/json"
    }
  ],
  "providers": [
    { "name": "Aerial Surveys", "roles": ["producer"] },
    { "name": "Aerial Surveys", "roles": ["licensor"] },
    {
      "name": "Toitū Te Whenua Land Information New Zealand",
      "roles": ["host", "processor"]
    }
  ],
  "linz:lifecycle": "preview",
  "linz:geospatial_category": "satellite-imagery",
  "linz:region": "manawatu-whanganui",
  "linz:security_classification": "unclassified",
  "linz:event_name": "Storm",
  "linz:geographic_description": "Palmerston North Area",
  "extent": {
    "spatial": {
      "bbox": [[175.4961876, -36.8000575, 175.5071491, -36.7933469]]
    },
    "temporal": {
      "interval": [["2022-12-31T11:00:00Z", "2022-12-31T11:00:00Z"]]
    }
  }
}

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@paulfouquet paulfouquet changed the title feat: add new fields from LINZ STAC extension to the Collection TDE-985 feat!: add new fields to the Collection TDE-985 Jan 9, 2024
@paulfouquet paulfouquet marked this pull request as ready for review January 9, 2024 21:49
@paulfouquet paulfouquet requested a review from a team as a code owner January 9, 2024 21:49
@paulfouquet paulfouquet changed the title feat!: add new fields to the Collection TDE-985 feat: add new fields to the Collection TDE-985 Jan 10, 2024
@paulfouquet paulfouquet requested review from l0b0 and blacha January 10, 2024 02:22
l0b0
l0b0 previously approved these changes Jan 10, 2024
@paulfouquet paulfouquet changed the title feat: add new fields to the Collection TDE-985 feat!: add new fields to the Collection TDE-985 Jan 16, 2024
@paulfouquet paulfouquet requested a review from l0b0 January 16, 2024 03:18
l0b0
l0b0 previously approved these changes Jan 16, 2024
amfage
amfage previously approved these changes Jan 18, 2024
@paulfouquet paulfouquet dismissed stale reviews from amfage and l0b0 via 795f004 January 23, 2024 22:35
@paulfouquet paulfouquet added this pull request to the merge queue Jan 26, 2024
Merged via the queue into master with commit 78016f6 Jan 26, 2024
1 check passed
@paulfouquet paulfouquet deleted the feat/use-linz-stac-extension-for-collection-TDE-985 branch January 26, 2024 04:03
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
github-merge-queue bot pushed a commit to linz/topo-workflows that referenced this pull request Feb 8, 2024
#### Motivation

The `standardise_validate.py` `--location` argument becomes
`--geographic-description`
(linz/topo-imagery#765).

#### Modification

- Update the `standardise-validate` task to take account of the
parameter change.
- Upgrade default version of the `topo-imagery` container.

#### Checklist

- [ ] Tests updated - N/A
- [x] Docs updated
- [x] Issue linked in Title

---------

Co-authored-by: Victor Engmark <[email protected]>
github-merge-queue bot pushed a commit to linz/topo-workflows that referenced this pull request Feb 8, 2024
#386)

#### Motivation

`collection_from_items.py` script is going to accept identifiers for
`--category` (linz/topo-imagery#765)

#### Modification

Change the `category` enum to a list of identifier instead of human
readable names.

#### Checklist

- [ ] Tests updated N/A
- [x] Docs updated
- [x] Issue linked in Title
amfage pushed a commit to linz/topo-workflows that referenced this pull request Feb 13, 2024
#### Motivation

The `standardise_validate.py` `--location` argument becomes
`--geographic-description`
(linz/topo-imagery#765).

#### Modification

- Update the `standardise-validate` task to take account of the
parameter change.
- Upgrade default version of the `topo-imagery` container.

#### Checklist

- [ ] Tests updated - N/A
- [x] Docs updated
- [x] Issue linked in Title

---------

Co-authored-by: Victor Engmark <[email protected]>
amfage pushed a commit to linz/topo-workflows that referenced this pull request Feb 13, 2024
#386)

#### Motivation

`collection_from_items.py` script is going to accept identifiers for
`--category` (linz/topo-imagery#765)

#### Modification

Change the `category` enum to a list of identifier instead of human
readable names.

#### Checklist

- [ ] Tests updated N/A
- [x] Docs updated
- [x] Issue linked in Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants