generated from linz/template-python-hello-world
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add new fields to the Collection TDE-985 #765
Merged
paulfouquet
merged 22 commits into
master
from
feat/use-linz-stac-extension-for-collection-TDE-985
Jan 26, 2024
Merged
feat!: add new fields to the Collection TDE-985 #765
paulfouquet
merged 22 commits into
master
from
feat/use-linz-stac-extension-for-collection-TDE-985
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
commented
Dec 5, 2023
paulfouquet
changed the title
feat: add new fields from LINZ STAC extension to the Collection TDE-985
feat!: add new fields to the Collection TDE-985
Jan 9, 2024
blacha
reviewed
Jan 9, 2024
blacha
reviewed
Jan 9, 2024
blacha
reviewed
Jan 9, 2024
l0b0
reviewed
Jan 10, 2024
paulfouquet
changed the title
feat!: add new fields to the Collection TDE-985
feat: add new fields to the Collection TDE-985
Jan 10, 2024
l0b0
previously approved these changes
Jan 10, 2024
Merged
3 tasks
paulfouquet
changed the title
feat: add new fields to the Collection TDE-985
feat!: add new fields to the Collection TDE-985
Jan 16, 2024
3 tasks
l0b0
previously approved these changes
Jan 16, 2024
amfage
previously approved these changes
Jan 18, 2024
amfage
approved these changes
Jan 23, 2024
MDavidson17
approved these changes
Jan 24, 2024
paulfouquet
deleted the
feat/use-linz-stac-extension-for-collection-TDE-985
branch
January 26, 2024 04:03
Merged
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Feb 8, 2024
#### Motivation The `standardise_validate.py` `--location` argument becomes `--geographic-description` (linz/topo-imagery#765). #### Modification - Update the `standardise-validate` task to take account of the parameter change. - Upgrade default version of the `topo-imagery` container. #### Checklist - [ ] Tests updated - N/A - [x] Docs updated - [x] Issue linked in Title --------- Co-authored-by: Victor Engmark <[email protected]>
github-merge-queue bot
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Feb 8, 2024
#386) #### Motivation `collection_from_items.py` script is going to accept identifiers for `--category` (linz/topo-imagery#765) #### Modification Change the `category` enum to a list of identifier instead of human readable names. #### Checklist - [ ] Tests updated N/A - [x] Docs updated - [x] Issue linked in Title
amfage
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Feb 13, 2024
#### Motivation The `standardise_validate.py` `--location` argument becomes `--geographic-description` (linz/topo-imagery#765). #### Modification - Update the `standardise-validate` task to take account of the parameter change. - Upgrade default version of the `topo-imagery` container. #### Checklist - [ ] Tests updated - N/A - [x] Docs updated - [x] Issue linked in Title --------- Co-authored-by: Victor Engmark <[email protected]>
amfage
pushed a commit
to linz/topo-workflows
that referenced
this pull request
Feb 13, 2024
#386) #### Motivation `collection_from_items.py` script is going to accept identifiers for `--category` (linz/topo-imagery#765) #### Modification Change the `category` enum to a list of identifier instead of human readable names. #### Checklist - [ ] Tests updated N/A - [x] Docs updated - [x] Issue linked in Title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Giving more details to the data consumers about the dataset.
Modification
Along with recently added arguments to the Collection creation, some new ones have been added (optional and mandatory).
Also simplify the data category management (Enum to Dict).
A Pull Request on https://github.com/linz/topo-workflows/ is coming to pass the new fields from Argo Workflows.
Notes:
It should be clarified if it isEDIT: It has been confirmed thatScanned Aerial Photos
orScanned Aerial Imagery
as there is currently a difference between the category in this repo and intopo-workflows
: https://linz.slack.com/archives/C01BWPHA1EU/p1704857340969749?thread_ts=1704837645.540939&cid=C01BWPHA1EUScanned Aerial Photos
should be used. fix: scanned aerial imagery does not exist in topo-imagery TDE-955 topo-workflows#398Example:
Checklist
If not applicable, provide explanation of why.