Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script to convert ascii files TDE-814 #595

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Conversation

MDavidson17
Copy link
Contributor

@MDavidson17 MDavidson17 commented Aug 9, 2023

(Built on top of multithreading branch will rebase onto master and mark ready for review when that PR is merged)

Includes some refactoring of existing listing/downloading code to avoid duplication:

  • list_json_in_uri -> list_uri

Has successfully run on a edited workflow in argo:
image

@MDavidson17 MDavidson17 force-pushed the feat/asc-files branch 3 times, most recently from e96c88a to 7b84c92 Compare August 11, 2023 04:15
@MDavidson17 MDavidson17 marked this pull request as ready for review August 23, 2023 02:54
@MDavidson17 MDavidson17 requested a review from a team as a code owner August 23, 2023 02:54
scripts/translate_ascii.py Outdated Show resolved Hide resolved
scripts/translate_ascii.py Outdated Show resolved Hide resolved
scripts/translate_ascii.py Outdated Show resolved Hide resolved
scripts/files/fs_s3.py Outdated Show resolved Hide resolved
scripts/translate_ascii.py Outdated Show resolved Hide resolved
amfage
amfage previously approved these changes Aug 29, 2023
scripts/translate_ascii.py Outdated Show resolved Hide resolved
scripts/translate_ascii.py Outdated Show resolved Hide resolved
scripts/translate_ascii.py Outdated Show resolved Hide resolved
scripts/translate_ascii.py Show resolved Hide resolved
@MDavidson17 MDavidson17 added this pull request to the merge queue Sep 26, 2023
Merged via the queue into master with commit 5875d53 Sep 26, 2023
1 check passed
@MDavidson17 MDavidson17 deleted the feat/asc-files branch September 26, 2023 20:20
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
github-merge-queue bot pushed a commit to linz/topo-workflows that referenced this pull request Sep 27, 2023
 (#161)

This workflow, converts all ascii files within a specified path to
tiffs, it then runs standardising and publish as per normal on the
translated data.

~~Waiting for: linz/topo-imagery#595


https://argo.linzaccess.com/workflows/argo/test-mdavidson-ascii9cc75?tab=workflow


![image](https://github.com/linz/topo-workflows/assets/33814653/681ad704-c34e-4953-9d7f-82a3cc575972)

sample output:
`s3://linz-workflow-artifacts/mdavidson/canterbury/cheviot_2015/dem_1m/2193/`

**Example test:**
```bash
argo submit ~/dev/topo-workflows/workflows/imagery/ascii-standardise-publish.yaml -n argo -f ~/dev/topo-workflows/workflows/imagery/canterbury-test.yaml --generate-name test-ascii

```

`canterbury-test.yaml`:
```yaml
"source": "s3://linz-elevation-staging/lidar2/Canterbury_-_Cheviot_LiDAR_(2015)/Canterbury_-_Cheviot_LiDAR_1m_DEM_(2015)/"
"target": "s3://linz-workflow-artifacts/mdavidson/canterbury/cheviot_2015/dem_1m/2193/"
"title": "Canterbury - Cheviot LiDAR 1m DEM (2015)"
"description": "Digital Elevation Model within the Canterbury - Cheviot region captured in 2015."
"start-datetime": "2015-04-01"
"end-datetime": "2015-04-01"
"scale": "10000"
"source-epsg": "2193"
"target-epsg": "2193"
"compression": "dem_lerc"
"retile": "true"
"validate": "false"
"group": "5"
"licensor": "Environment Canterbury"
"licensor-list": ""
"producer": "Aerial Surveys"
"producer-list": ""
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants