feat: set default current-date for collection_from_items script TDE-1298 #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
changed the title
amfage
approved these changes
Nov 28, 2024
paulfouquet
deleted the
feat/set-default-date-collection-from-items-tde-1298
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2024
🤖 I have created a release *beep* *boop* --- ## [7.1.0](v7.0.0...v7.1.0) (2024-11-28) ### Features * set default current-date for collection_from_items script TDE-1298 ([#1196](#1196)) ([e22bb66](e22bb66)) ### Bug Fixes * Use client syntax for getting file contents ([#1194](#1194)) ([ab83041](ab83041)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As a basemaps developer, I do not want to set many mandatory CLI arguments.
Modifications
Added the current date / time as a semi-sane default for the --current-date command line argument
Verification
pytest