Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor fake collection metadata #1096

Merged
merged 5 commits into from
Sep 29, 2024
Merged

test: refactor fake collection metadata #1096

merged 5 commits into from
Sep 29, 2024

Conversation

paulfouquet
Copy link
Collaborator

Motivation

The collection metadata used for testing is duplicated in the code base which makes it difficult to maintain.

Modifications

Use the same collection metadata for all the related tests.

Verification

ran pytest

@paulfouquet paulfouquet requested a review from a team as a code owner September 26, 2024 02:21
@paulfouquet paulfouquet marked this pull request as draft September 26, 2024 02:22
@paulfouquet paulfouquet marked this pull request as ready for review September 26, 2024 03:00
l0b0
l0b0 previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@l0b0 l0b0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Included one simplification which is not necessary to do in this PR.

scripts/stac/imagery/tests/conftest.py Outdated Show resolved Hide resolved
@paulfouquet paulfouquet requested a review from l0b0 September 27, 2024 02:33
@paulfouquet paulfouquet added this pull request to the merge queue Sep 29, 2024
Merged via the queue into master with commit eed97de Sep 29, 2024
2 checks passed
@paulfouquet paulfouquet deleted the test/refactor-fake-collection-metadata branch September 29, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0b0 l0b0 l0b0 approved these changes

@blacha blacha Awaiting requested review from blacha blacha is a code owner automatically assigned from linz/li-topo-data-engineering

@amfage amfage Awaiting requested review from amfage amfage is a code owner automatically assigned from linz/li-topo-data-engineering

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfouquet @l0b0