feat: TDE-452 create imagery stac item #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfouquet
reviewed
Aug 22, 2022
paulfouquet
reviewed
Aug 22, 2022
paulfouquet
reviewed
Aug 22, 2022
paulfouquet
reviewed
Aug 22, 2022
paulfouquet
reviewed
Aug 22, 2022
MDavidson17
force-pushed
the
feat/create_stac
branch
from
efd5e34 to
ebeafa8
Compare
get version number from global variable
replaced by a better function in a different pr
MDavidson17
force-pushed
the
feat/create_stac
branch
from
ebeafa8 to
12da548
Compare
paulfouquet
reviewed
Aug 28, 2022
amfage
requested changes
Aug 31, 2022
Co-authored-by: Alice Fage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pystac was only used to get the stac version, this can be hardcoded and pystac removed entirely, or the code can be changed to return a pystac item object.-pystac removednb: The code has been implemented with thought of how the
create_stac_items.pyscript might run for different datasets.How it is currently written it could be possible to add a datatype dropdown input in the argo workflow and use this datatype to determine what stac to create.
In topo-processor this was premtively scripted, however on reflection the developers mentioned they wouldn't have implemented it until there were additional datasets, therefore it has not been implemented yet in topo-imagery.