Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Docker initialization scripts to respect CELLS_WORKING_DIR environment variable and eliminate hardcoded /config paths. #16

Closed
wants to merge 2 commits into from

Conversation

zales
Copy link

@zales zales commented Mar 8, 2024

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

This pull request introduces modifications to the Docker initialization scripts, aiming to increase configurability and maintainability.

Benefits of this PR and context:

Previously, these scripts had hardcoded references to the /config path, which posed limitations on the customization and deployment of the application in different environments. By leveraging the CELLS_WORKING_DIR environment variable, these changes allow for greater flexibility in specifying the configuration directory.

How Has This Been Tested?

I tested it on macbook pro (arm64) and rpi 5 (arm64). I tried first start,restart, initialization and update.

Source / References:

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/pydio-cells/v4.3.6-pkg-369bddbf-dev-35173bc078f85bff5ff9ffa0bd2f6af3a29ca05f-pr-16/index.html
https://ci-tests.linuxserver.io/lspipepr/pydio-cells/v4.3.6-pkg-369bddbf-dev-35173bc078f85bff5ff9ffa0bd2f6af3a29ca05f-pr-16/shellcheck-result.xml

Tag Passed
amd64-v4.3.6-pkg-369bddbf-dev-35173bc078f85bff5ff9ffa0bd2f6af3a29ca05f-pr-16
arm64v8-v4.3.6-pkg-369bddbf-dev-35173bc078f85bff5ff9ffa0bd2f6af3a29ca05f-pr-16

@aptalca
Copy link
Member

aptalca commented Mar 8, 2024

Thanks for the PR, but. . .

/config is an internal path that is meant to contain all persistent data and is meant to be bind mounted to whatever path you like on host.

So I don't really see the point of this proposed change

@zales
Copy link
Author

zales commented Mar 8, 2024

Thanks for the PR, but. . .

/config is an internal path that is meant to contain all persistent data and is meant to be bind mounted to whatever path you like on host.

So I don't really see the point of this proposed change

I didn't want to store all persistent data in /config. I think the path name is confusing. Even if it's just an internal path.

But I understand, thanks anyway for the answer. I'm closing the PR.

Have a nice day.

@zales zales closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants