Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync nginx conf with upstream nextcloud docs #392

Merged
merged 5 commits into from
Dec 22, 2023

Conversation

calvin-li-developer
Copy link
Contributor

@calvin-li-developer calvin-li-developer commented Dec 22, 2023

linuxserver.io


  • [ ✔️ ] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Updates site default conf to upstream configurations.

Benefits of this PR and context:

closes #391 and #388

How Has This Been Tested?

I have done it manually in my nextcloud instance and it seems to fix a log-reader issue and activities tab issue.

Source / References:

https://docs.nextcloud.com/server/latest/admin_manual/installation/nginx.html

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-1a559c989305f1c8658b7234019133d9f557ca03-pr-392/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-1a559c989305f1c8658b7234019133d9f557ca03-pr-392/shellcheck-result.xml

Tag Passed
amd64-28.0.0-pkg-86e5344c-dev-1a559c989305f1c8658b7234019133d9f557ca03-pr-392
arm64v8-28.0.0-pkg-86e5344c-dev-1a559c989305f1c8658b7234019133d9f557ca03-pr-392

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-5abf9b3d36c2a6d01e9f202da98eee818d76defc-pr-392/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-5abf9b3d36c2a6d01e9f202da98eee818d76defc-pr-392/shellcheck-result.xml

Tag Passed
amd64-28.0.0-pkg-86e5344c-dev-5abf9b3d36c2a6d01e9f202da98eee818d76defc-pr-392
arm64v8-28.0.0-pkg-86e5344c-dev-5abf9b3d36c2a6d01e9f202da98eee818d76defc-pr-392

@calvin-li-developer calvin-li-developer changed the title sync nginx conf with upstream nextcloud docs. closes #391 sync nginx conf with upstream nextcloud docs Dec 22, 2023
@thespad
Copy link
Member

thespad commented Dec 22, 2023

Please revert the fastcgi_pass/php-handler change as it would diverge from our other containers unnecessarily, but otherwise looks good and I'm happy to approve it.

@calvin-li-developer
Copy link
Contributor Author

Please revert the fastcgi_pass/php-handler change as it would diverge from our other containers unnecessarily, but otherwise looks good and I'm happy to approve it.

done.

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-07a04516b1667d2c879ae581663d73b79b25a65e-pr-392/index.html
https://ci-tests.linuxserver.io/lspipepr/nextcloud/28.0.0-pkg-86e5344c-dev-07a04516b1667d2c879ae581663d73b79b25a65e-pr-392/shellcheck-result.xml

Tag Passed
amd64-28.0.0-pkg-86e5344c-dev-07a04516b1667d2c879ae581663d73b79b25a65e-pr-392
arm64v8-28.0.0-pkg-86e5344c-dev-07a04516b1667d2c879ae581663d73b79b25a65e-pr-392

@thespad thespad merged commit 20c6337 into linuxserver:master Dec 22, 2023
3 checks passed
@aptalca
Copy link
Member

aptalca commented Dec 22, 2023

Version header is duplicate

@calvin-li-developer
Copy link
Contributor Author

Version header is duplicate

ops forgot to delete the previous line. haha. I think @thespad fixed it. Thanks! 😊

# only for Nextcloud like below:
include mime.types;
types {
text/javascript js mjs;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove js since the mine.type already includes application/javascript js;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Nextcloud Log Error in 28.0.1 fixed but need change default.conf also
5 participants