-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync nginx conf with upstream nextcloud docs #392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
I am a bot, here are the test results for this PR:
|
Please revert the fastcgi_pass/php-handler change as it would diverge from our other containers unnecessarily, but otherwise looks good and I'm happy to approve it. |
done. |
I am a bot, here are the test results for this PR:
|
Version header is duplicate |
ops forgot to delete the previous line. haha. I think @thespad fixed it. Thanks! 😊 |
# only for Nextcloud like below: | ||
include mime.types; | ||
types { | ||
text/javascript js mjs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove js since the mine.type already includes application/javascript js;
Description:
Updates site default conf to upstream configurations.
Benefits of this PR and context:
closes #391 and #388
How Has This Been Tested?
I have done it manually in my nextcloud instance and it seems to fix a log-reader issue and activities tab issue.
Source / References:
https://docs.nextcloud.com/server/latest/admin_manual/installation/nginx.html